Cargo.lock

@@ -173,7 +173,7 @@ checksum = "e496a50fda8aacccc86d7529e2c1e0892dbd0f898a6b5645b5561b89c3210efa"
 
 [[package]]
 name = "day-reporter"
-version = "2.0.0"
+version = "0.1.0"
 dependencies = [
  "anyhow",
  "chrono",

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "day-reporter"
-version = "2.0.0"
+version = "0.1.0"
 edition = "2021"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

README.md

@@ -1,38 +1,41 @@
 # things-3-report
-A small program written in rust that digests my Things tasks into a format for Slack reporting.
+A small script to generate bulleted reports from my Things 3 tasks
 
-Tasks are pulled out of Things using AppleScript over a JavaScript OSA Bridge. Tasks are then filtered
-and formatted based on the selected format schema.
-
-## Options
-See `day-reporter -h` for a current list of options
-
-## Basic Task format
-A task is returned as a markdown list element containing its title and optionally a list of information parsed from
-related tag sections in the notes portion of the task.
-
-Tag specific additional bullets are included using a triple backtick (like GitHub code block markdown). Then instead of
-specifying the coding style as you would (for example `typescript`) you specify the relevant tag: `MyTag`. Running the
-program with a given `--tags` argument will cause related tag blocks to be included as sub-bullets.
-
-### Example
-
-<pre>
-```MyTag
-Some notes
+## Usage
+The environment should be provided by `nix-shell`. Alternatively you can install the requirements directly with
+```bash
+$ pip install -r requirements.txt
 ```
-</pre>
+To run the script, pass in the tag or list of tags to filter on. Projects and Tasks lacking one of the specified tags will be excluded from the generated report. I have a `Report` tag which I use for this. If a project is tagged with the tag, all tasks are considered tagged even if not explicitly done so.
 
-will result in "Some notes" being included with the task
+### Specific functionality
+I have also included a few pieces of additional functionality:
+- The project is headed with a set of 3 randomly selected emojis from `emojis.txt`
+- If you have a person's name in the task or project title, you can add an `@<Persons Name>` tag to the task or project and the script will automatically replace the vowels in their name with unicode that looks similar. This allows you to post the list on slack without generating mentions.
+- Adding a code block that begins with `report` will cause the script to dump the contents into the end of the generated message. This can be used to add notes to the generated output.
+- Be default the script draws from today's current list of tasks. If you specify `--signoff` it will instead draw on completed tasks from your logbook. (This is useful for an end of the day message).
 
-## Name Sanitization
-Name tags found on projects and tasks are automatically sanitized by replacing vowel characters with lookalikes. This
-behavior can be disabled with the `--no-sanitize` argument.
+## Example Usage:
+Given a set of tasks tagged `Report`
+```txt
+Project named "Some Project" tagged as Report:
+  containing two tasks (not necessarily tagged) "Task 1" and "Task 2"
 
-## Project Formatting
-Projects make up a bullet level above tasks. Any tasks in the project will be nested under the project title following
-and project specific matched tag block comments in the project notes.
+A top level task called some task with a notes filed containing
+```report
+(#9999)[https://example.com]
+`` ` <-- No space there but it's hard to escape these ticks
+```
 
-## Area Formatting
-Areas collect up projects, but instead of indenting them further, Area's are returned as section titles above the
-generated output. If only one area contains all of the reported tasks, then the area name is omitted entirely.
+```
+$ python dump.py Report
+```
+will generate:
+
+```txt
+:emoji: :emoji: :emoji:
+  - Some Project
+    - Task 1
+    - Task 2
+  - Some Task (#9999)(https://example.com)
+```

REFACTOR.md

@@ -0,0 +1,15 @@
+# Refactor Goals
+1. Speed things up. Relying on things.py (and python in general) makes the code slow. Add in the fact that the
+`nix-shell` logic tends to run every day and pulls down the universe, the current day reporter is quite slow
+2. Clean up the code. Using a better language will help some, but in particular using a bonafide templating library
+should improve the code.
+3. Stability. Using `osascript` with the Things AppleScript API will avoid future problems that `things.py` is
+constantly running into because they are overly coupled to the Things sqlite database schema.
+
+# Ideas
+- Move to rust using `osascript` to drive interactions with things
+- Write a small library of scripts in JS that rely on the OSA infrastructure to call out to things, and package up
+content into JSON for ease of use in rust.
+
+# Resources
+I found a really great gists for working with osascript and it even has Things examples: https://gist.github.com/tommorris/99bcbbcf445bb6475797

src/emoji/emoji_list.txt

@@ -1,22 +1,15 @@
 :audioowl:
 :ayaya:
 :blobcat_cookie:
-:blobcat_munch:
 :boat-cat:
 :bouquet_owl:
 :cat-confused:
 :cat-cook:
-:cat-dance:
 :cat-on-the-laptop:
-:cat-peek:
 :cat-roll:
-:cat-roomba-exceptionally-fast:
-:cat-roomba:
 :cat-shook:
 :cat-skype:
 :cat_blush:
-:cat_bobble:
-:cat_clap:
 :cat_type:
 :catcat:
 :catdance:
@@ -38,27 +31,22 @@
 :dancing_dog:
 :deadowl:
 :dnowl:
-:dog_cool:
-:doge-dance-kfc:
 :doge:
 :dogjam:
 :eikaiwaowl:
-:eve-owl-evil:
 :eve-owl:
+:eve-owl-evil:
 :fakeowl:
-:french-bulldog_massage:
 :gatocat:
 :grumpycat:
 :gull_scream:
 :heart-eyes-dog:
 :hungry_cat:
 :i_regret_nothing:
-:insomnia-owl:
 :investigate-owl:
 :jakethedog1:
 :jakethedog2:
 :jenkinsowl:
-:long_cat:
 :look-owl:
 :loopyowl:
 :love_letter_owl:
@@ -79,8 +67,8 @@
 :meow_buzz:
 :meow_camera:
 :meow_code:
-:meow_coffee2:
 :meow_coffee:
+:meow_coffee2:
 :meow_comfy:
 :meow_comfy_coffee:
 :meow_comfydonut:
@@ -138,12 +126,9 @@
 :meowth:
 :mild-surprise-owl:
 :nerd-cat:
-:nerdcat:
 :octocat1:
 :octocat2:
 :octocat3:
-:ok-owl:
-:omg-owl:
 :owl-travel:
 :owl_celebration:
 :owl_christmas_stocking:
@@ -164,9 +149,7 @@
 :realowl_back:
 :realowl_guruguru:
 :realowl_side:
-:rodger-owl:
 :sakura_owl:
-:seems-good-owl:
 :shrodingers-cat:
 :steampunk-owl:
 :stopowl:

src/main.rs

@@ -1,116 +1,65 @@
 mod things;
 mod reporter;
 mod emoji;
-mod names;
 
-use reporter::{MarkdownReporter, Reporter, Resolution, ReportOptions};
+use reporter::{MarkdownReporter, Reporter};
 
 use things::task::Task;
 use anyhow::Result;
 use clap::{Parser, ValueEnum};
 
 #[derive(ValueEnum, Copy, Clone, Eq, PartialEq)]
-enum ListType {
-    /// Generate a report from the Things today list
-    Today,
-    /// Generate a report from the Things logbook
-    Logbook,
+enum Modes {
+    /// Generate a report containing projected work for the day and a morning message
+    Morning,
+    /// Generate a report that is intended to be used for sharing what major tasks were completed
+    /// in the last cycle.
+    Cycle,
+    /// Generate a report for what was actually done today and a signoff message
+    Signoff,
 }
 
-impl ListType {
-    fn format_tasks(&self, tasks: Vec<Task>, tags: &Vec<String>, sanitize_names: bool, resolution: Resolution) -> String {
+impl Modes {
+    fn format_tasks(&self, task_report: &str) -> String {
         match self {
-            ListType::Today => {
-                MarkdownReporter.report(tasks, &ReportOptions {
-                    resolution,
-                    tags: tags.to_vec(),
-                    sanitize_names,
-                })
-            },
-            ListType::Logbook => {
-                MarkdownReporter.report(tasks, &ReportOptions {
-                    resolution,
-                    tags: tags.to_vec(),
-                    sanitize_names,
-                })
-            },
+            Modes::Morning => format!("{}\n\n{}", emoji::pick(3).join(" "), task_report),
+            Modes::Signoff => format!("Stopping now\n\n{}", task_report),
+            Modes::Cycle => format!("*Cycle Report*\n\n{}", task_report),
         }
     }
 }
 
-impl Default for ListType {
-    fn default() -> ListType {
-        ListType::Today
+impl Default for Modes {
+    fn default() -> Modes {
+        Modes::Morning
     }
 }
 
-/// A program that generates Slack flavor markdown reports from Things 3 todo list items.
 #[derive(Parser)]
 #[command(author, version, about, long_about = None)]
 struct CliArgs {
-    /// A list of tags to filter todos by. Only todo list items with every tag will be reported
+    /// A list of tags to filter requests on
     #[arg(short, long)]
     tags: Vec<String>,
 
-    /// A list of tags to specifically omit from the results. Only todo list items WITHOUT these
-    /// tags will be included
-    #[arg(short, long)]
-    omit: Vec<String>,
-
-    /// Select the type of report to generate
-    #[arg(short, long, default_value_t = ListType::default())]
+    /// Control what type of report to generate
+    #[arg(short, long, default_value_t = Modes::default())]
     #[clap(value_enum)]
-    list: ListType,
-
-    /// By default, any @<name> style tags will be sanitized in the output to avoid @-mentions in
-    /// Slack. This is done by replacing vowel characters with unicode lookalikes. If this
-    /// flag is set then the names will be passed through unsanitized.
-    #[arg(long, default_value_t = false)]
-    no_sanitize: bool,
-
-    /// An ISO date string for when to filter tasks from.
-    /// Defaults to midnight this morning if unset. Not used for the today list
-    #[arg(long)]
-    from: Option<String>,
-
-    /// An ISO date string for when to filter tasks until.
-    /// Defaults to 1 second before midnight tonight if unset. Not used for the today list
-    #[arg(long)]
-    to: Option<String>,
-
-    /// An optional message to include at the beginning of the report. If omitted, 3 random emojis
-    /// will be included instead
-    #[arg(short, long)]
-    message: Option<String>,
-
-    /// Choose a resolution for the report. This will determine how much detail is included in the
-    /// output. Default is "FullTask"
-    #[arg(short, long, default_value_t = Resolution::default())]
-    #[clap(value_enum)]
-    resolution: Resolution,
+    mode: Modes,
 }
 
 fn main() -> Result<()> {
     let args = CliArgs::parse();
-    let now = chrono::Local::now();
-    let from = args.from.unwrap_or_else(|| now.date().and_hms(0, 0, 0).to_rfc3339());
-    let to = args.to.unwrap_or_else(|| (now + chrono::Duration::days(1)).date().and_hms(0, 0, 0).to_rfc3339());
-
-    let message = args.message.unwrap_or_else(|| emoji::pick(3).join(" "));
-
-    let tasks = match args.list {
-        ListType::Today => Task::today(&from, &to),
-        ListType::Logbook => Task::logbook(&from, &to),
+    let tasks = match args.mode {
+        Modes::Morning => Task::today(),
+        Modes::Signoff => Task::logbook_today(),
+        Modes::Cycle => Task::logbook_this_cycle(),
     }?;
-    let mut reported: Vec<Task> = tasks.into_iter().filter(|task| {
-        // Filter down to tasks with all selected tags and without any of the omitted tags
-        args.tags.iter().all(|tag| task.has_tag(tag)) && !args.omit.iter().any(|tag| task.has_tag(tag))
+    let reported: Vec<Task> = tasks.into_iter().filter(|task| {
+        args.tags.iter().all(|tag| task.has_tag(tag))
     }).collect();
-    reported.sort_by(|a, b| {
-        a.completion_date.cmp(&b.completion_date)
-    });
-    let report = args.list.format_tasks(reported, &args.tags, !args.no_sanitize, args.resolution);
-    println!("{message}\n\n{report}");
+    let report = args.mode.format_tasks(&MarkdownReporter.report(reported));
+    println!("{report}");
 
     Ok(())
 }

src/names.rs

@@ -1,39 +0,0 @@
-fn sanitize(src: &str) -> String {
-    // NOTE: The values on the right are _NOT_ the characters they appear to be.
-    src.replace("a", "а")
-        .replace("e", "e")
-        .replace("i", "і")
-        .replace("o", "о")
-        .replace("u", "ս")
-}
-
-/// Replace vowel characters with look alikes to avoid Slack mention logic
-/// # Args
-/// - `src`: The source text to modify
-/// - `names`: The set of names to sanitize
-fn sanitize_strings<'a>(src: &'a str, names: &Vec<String>) -> String {
-    let sanitization_strings = names.iter()
-        .map(|name| (name, sanitize(name)))
-        .collect::<Vec<(&String, String)>>();
-    let mut dest = src.to_string();
-    for (name, replacement) in sanitization_strings {
-        dest = dest.replace(name, &replacement);
-    }
-    return dest;
-}
-
-fn extract_names_from_tags(tags: &Vec<String>) -> Vec<String> {
-    tags
-        .iter()
-        .filter(|t| t.starts_with("@"))
-        .map(|t| {
-            let formatted_name = t.strip_prefix("@").expect(&format!("{t} should have started with @"));
-            String::from(formatted_name)
-        })
-        .collect()
-}
-
-pub fn sanitize_names(src: &str, tags: &Vec<String>) -> String {
-    let name_tags = extract_names_from_tags(tags);
-    sanitize_strings(src, &name_tags)
-}

src/reporter.rs

@@ -1,45 +1,9 @@
-use clap::ValueEnum;
-
-use crate::things::task::{Task, Status};
-use crate::names::sanitize_names;
-
-/// Given a notes field and a list of possible tags for sections, return the content of triple tick
-/// blocks containing those tags
-///
-/// # Examples
-/// ```
-/// extract_tagged_notes(
-///     "\`\`\`report
-///     Something
-///     \`\`\`",
-///     vec![String::from("report")],
-/// ); // -> "Something"
-/// ```
-///
-fn extract_tagged_notes(notes: &str, tags: &Vec<String>) -> Vec<String> {
-    notes
-        .split("```")
-        .into_iter()
-        .map(|section| -> (&str, Option<&String>) {
-            (section, tags.iter().find(|t| section.starts_with(*t)))
-        })
-        .filter(|(_section, tag)| { tag.is_some() })
-        .map(|(section, tag)| {
-            let start_tag = tag.unwrap();
-            section.strip_prefix(start_tag)
-                .map(|s| s.trim())
-                .expect("Failed to strip start tag prefix").to_string()
-        })
-        .collect()
-}
-
+use crate::things::task::Task;
 
 #[derive(Debug)]
 pub struct ProjectTree {
     id: String,
     title: String,
-    notes: Option<String>,
-    tags: Vec<String>,
     tasks: Vec<Task>,
 }
 
@@ -61,8 +25,8 @@ pub struct ThingsTree {
 impl AreaTree {
     fn new(id: &str, title: &str) -> AreaTree {
         AreaTree {
-            id: id.to_string(),
-            title: title.to_string(),
+            id: id.clone().to_string(),
+            title: title.clone().to_string(),
             projects: vec![],
             hanging_tasks: vec![],
         }
@@ -75,8 +39,6 @@ impl AreaTree {
                 self.projects.push(ProjectTree {
                     id: project.id.clone(),
                     title: project.title.clone(),
-                    notes: project.notes.clone(),
-                    tags: project.tags.clone(),
                     tasks: vec![task],
                 });
             }
@@ -107,8 +69,6 @@ impl ThingsTree {
                     self.hanging_projects.push(ProjectTree {
                         id: project.id.clone(),
                         title: project.title.clone(),
-                        notes: project.notes.clone(),
-                        tags: project.tags.clone(),
                         tasks: vec![task],
                     });
                 }
@@ -128,40 +88,22 @@ impl ThingsTree {
     }
 }
 
-#[derive(ValueEnum, Copy, Clone, Eq, PartialEq)]
-pub enum Resolution {
-    FullTask,
-    Project,
-}
-
-impl Default for Resolution {
-    fn default() -> Resolution {
-        Resolution::FullTask
-    }
-}
-
-pub struct ReportOptions {
-    pub resolution: Resolution,
-    pub tags: Vec<String>,
-    pub sanitize_names: bool,
-}
-
 pub trait Reporter {
-    fn report_task(&mut self, task: &Task, depth: usize, options: &ReportOptions) -> String;
-    fn report_project(&mut self, project: &ProjectTree, depth: usize, options: &ReportOptions) -> String;
-    fn report_single_area(&mut self, area: &AreaTree, options: &ReportOptions) -> String;
-    fn report_multiple_areas(&mut self, areas: &Vec<AreaTree>, options: &ReportOptions) -> String;
-    fn report(&mut self, tasks: Vec<Task>, options: &ReportOptions) -> String {
+    fn report_task(&mut self, task: &Task, depth: usize) -> String;
+    fn report_project(&mut self, project: &ProjectTree, depth: usize) -> String;
+    fn report_single_area(&mut self, area: &AreaTree) -> String;
+    fn report_multiple_areas(&mut self, areas: &Vec<AreaTree>) -> String;
+    fn report(&mut self, tasks: Vec<Task>) -> String {
         let tree = ThingsTree::from_tasks(tasks);
         let untracked_tasks = tree.hanging_tasks
             .iter()
-            .map(|t| self.report_task(t, 0, options))
+            .map(|t| self.report_task(t, 0))
             .collect::<Vec<String>>()
             .join("\n");
         let area_tasks: String = match tree.areas.len() {
             0 => "".to_string(),
-            1 => self.report_single_area(&tree.areas[0], options),
-            _ => self.report_multiple_areas(&tree.areas, options),
+            1 => self.report_single_area(&tree.areas[0]),
+            _ => self.report_multiple_areas(&tree.areas),
         };
 
         let separator = if area_tasks == "" || untracked_tasks == "" {
@@ -177,83 +119,30 @@ pub trait Reporter {
 pub struct MarkdownReporter;
 
 impl Reporter for MarkdownReporter {
-    fn report_task(&mut self, task: &Task, depth: usize, options: &ReportOptions) -> String {
-        let relevant_notes = task.notes.clone()
-            .map(|notes| extract_tagged_notes(&notes, &options.tags))
-            .unwrap_or(vec![])
-            .iter()
-            .map(|l| format!("\n{}- {}", String::from(" ").repeat(depth + 4), l))
-            .collect::<Vec<String>>()
-            .join("");
-        let title = if task.status == Status::Canceled {
-            format!("~{}~", task.title)
-        } else {
-            task.title.to_string()
-        };
-        let mut output = format!("\n{}- {}{}", String::from(" ").repeat(depth), title, relevant_notes);
-        if options.sanitize_names {
-            output = sanitize_names(&output, &task.tags);
-        }
-
-        output
+    fn report_task(&mut self, task: &Task, depth: usize) -> String {
+        format!("{}- {}", String::from(" ").repeat(depth), task.title)
     }
-    fn report_project(&mut self, project: &ProjectTree, depth: usize, options: &ReportOptions) -> String {
-        let resolution = &options.resolution;
-        let relevant_notes = project.notes.clone()
-            .map(|notes| extract_tagged_notes(&notes, &options.tags))
-            .unwrap_or(vec![])
-            .iter()
-            .map(|l| format!("\n{}- {}", String::from(" ").repeat(depth + 4), l))
-            .collect::<Vec<String>>()
-            .join("");
-        let mut output = match resolution {
-            Resolution::FullTask => {
-                let tasks = project.tasks
-                    .iter()
-                    .map(|t| self.report_task(t, depth + 4, options))
-                    .collect::<Vec<String>>()
-                    .join("");
-                format!("{}{}{}{}", String::from(" ").repeat(depth), project.title, relevant_notes, tasks)
-            },
-            Resolution::Project => {
-                format!("{}- {}{}", String::from(" ").repeat(depth), project.title, relevant_notes)
-            }
-        };
-
-        if options.sanitize_names {
-            output = sanitize_names(&output, &project.tags);
-        }
-
-        output
+    fn report_project(&mut self, project: &ProjectTree, depth: usize) -> String {
+        let tasks = project.tasks.iter().map(|t| self.report_task(t, depth + 4)).collect::<Vec<String>>().join("\n");
+        format!("{}{}\n{}", String::from(" ").repeat(depth), project.title, tasks)
     }
-    fn report_single_area(&mut self, area: &AreaTree, options: &ReportOptions) -> String {
-        let project_reports = area.projects
-            .iter()
-            .map(|p| self.report_project(p, 0, options))
-            .collect::<Vec<String>>()
-            .join("\n");
-        let untracked_tasks = area.hanging_tasks
-            .iter()
-            .map(|t| self.report_task(t, 0, options))
-            .collect::<Vec<String>>()
-            .join("");
-        let separator = if project_reports == "" || untracked_tasks == "" {
+    fn report_single_area(&mut self, area: &AreaTree) -> String {
+        let project_tasks = area.projects.iter().map(|p| self.report_project(p, 0)).collect::<Vec<String>>().join("\n");
+        let untracked_tasks = area.hanging_tasks.iter().map(|t| self.report_task(t, 0)).collect::<Vec<String>>().join("\n");
+        let separator = if project_tasks == "" || untracked_tasks == "" {
             ""
         } else {
             "\n\n"
         };
-        match options.resolution {
-            Resolution::FullTask => format!("{}{}{}", project_reports, separator, untracked_tasks),
-            Resolution::Project => format!("{}", project_reports)
-        }
+        format!("{}{}{}", project_tasks, separator, untracked_tasks)
     }
-    fn report_multiple_areas(&mut self, areas: &Vec<AreaTree>, options: &ReportOptions) -> String {
+    fn report_multiple_areas(&mut self, areas: &Vec<AreaTree>) -> String {
         match areas.len() {
             0 => "".to_string(),
-            1 => self.report_single_area(&areas[0], options),
+            1 => self.report_single_area(&areas[0]),
             _ => {
                 areas.iter().map(|area| {
-                    let single = self.report_single_area(area, options);
+                    let single = self.report_single_area(area);
                     format!("*{}*\n{}", area.title, single)
                 })
                 .collect::<Vec<String>>()

src/things/logbook.js

@@ -2,36 +2,35 @@ var things = Application("Things");
 var logbook = things.lists.byName("Logbook").toDos();
 var objs = [];
 
-var from = new Date($params.from);
-var to = new Date($params.to);
+var from = new Date();
+from.setHours(0);
+from.setMinutes(0);
+from.setSeconds(0);
+var to = new Date();
+to.setTime(from.getTime());
+to.setHours(23);
+to.setMinutes(59);
+to.setSeconds(59);
 
-for (const todo of logbook) {
-  if(todo.completionDate() >= from && todo.completionDate() < to) {
-    var proj = todo.project();
-    var tags = [];
-    if (proj) {
-      tags.push(...proj.tagNames().split(', '));
-    }
-    var area = todo.area() || proj && proj.area();
-    objs.push({
-      id: todo.id(),
-      title: todo.name(),
-      notes: todo.notes() || null,
-      status: todo.status(),
-      completion_date: todo.completionDate(),
-      project: proj && {
-        id: proj.id(),
-        title: proj.name(),
-        status: proj.status(),
-        notes: proj.notes(),
-        tags: proj.tagNames().split(', '),
-      },
-      area: area && { id: area.id(), title: area.name() },
-      tags: [...tags, ...todo.tagNames().split(', ')].filter(t => t),
-    });
-  } else {
-    break;
+logbook.filter(task => {
+  return task.completionDate() >= from && task.completionDate() < to;
+}).forEach(todo => {
+  var proj = todo.project();
+  var tags = [];
+  if (proj) {
+    tags.push(...proj.tagNames().split(', '));
   }
-}
+  var area = todo.area() || proj && proj.area();
+  objs.push({
+    id: todo.id(),
+    title: todo.name(),
+    notes: todo.notes() || null,
+    status: todo.status(),
+    completion_date: todo.completionDate(),
+    project: proj && { id: proj.id(), title: proj.name() },
+    area: area && { id: area.id(), title: area.name() },
+    tags: [...tags, ...todo.tagNames().split(', ')].filter(t => t),
+  });
+});
 
 return JSON.stringify(objs, undefined, 2);

src/things/logbook_cycle.js

@@ -0,0 +1,36 @@
+var things = Application("Things");
+var logbook = things.lists.byName("Logbook").toDos();
+var objs = [];
+
+// From 6 weeks ago
+var from = new Date(new Date().getTime() - (6 * 7 * 24 * 60 * 60 * 1000));
+from.setHours(0);
+from.setMinutes(0);
+from.setSeconds(0);
+var to = new Date();
+to.setHours(23);
+to.setMinutes(59);
+to.setSeconds(59);
+
+logbook.filter(task => {
+  return task.completionDate() >= from && task.completionDate() < to;
+}).forEach(todo => {
+  var proj = todo.project();
+  var tags = [];
+  if (proj) {
+    tags.push(...proj.tagNames().split(', '));
+  }
+  var area = todo.area() || proj && proj.area();
+  objs.push({
+    id: todo.id(),
+    title: todo.name(),
+    notes: todo.notes() || null,
+    status: todo.status(),
+    completion_date: todo.completionDate(),
+    project: proj && { id: proj.id(), title: proj.name() },
+    area: area && { id: area.id(), title: area.name() },
+    tags: [...tags, ...todo.tagNames().split(', ')].filter(t => t),
+  });
+});
+
+return JSON.stringify(objs, undefined, 2);

src/things/task.rs

@@ -1,11 +1,11 @@
 use std::str::from_utf8;
-use serde::{Deserialize, Serialize};
+use serde::Deserialize;
 use anyhow::Result;
 use osascript;
 use serde_json;
 use chrono::{DateTime, Utc};
 
-#[derive(Deserialize, Debug, Eq, PartialEq)]
+#[derive(Deserialize, Debug)]
 pub enum Status {
     #[serde(rename = "completed")]
     Completed,
@@ -13,17 +13,12 @@ pub enum Status {
     Incomplete,
     #[serde(rename = "open")]
     Open,
-    #[serde(rename = "canceled")]
-    Canceled,
 }
 
 #[derive(Deserialize, Debug)]
 pub struct Project {
     pub id: String,
     pub title: String,
-    pub tags: Vec<String>,
-    pub notes: Option<String>,
-    pub status: Status,
 }
 
 #[derive(Deserialize, Debug)]
@@ -44,31 +39,27 @@ pub struct Task {
     pub area: Option<Area>,
 }
 
-#[derive(Serialize, Debug)]
-pub struct TaskParams {
-    // ISO string for the start date
-    from: String,
-    // ISO string for the end date
-    to: String,
-}
-
 impl Task {
     /// A Helper for loading Tasks from json returned by an osascript
-    fn from_script(script_bytes: &[u8], params: TaskParams) -> Result<Vec<Task>> {
+    fn from_script(script_bytes: &[u8]) -> Result<Vec<Task>> {
         let script = osascript::JavaScript::new(from_utf8(script_bytes)?);
-        let raw_json: String = script.execute_with_params(params)?;
+        let raw_json: String = script.execute()?;
         let tasks: Vec<Task> = serde_json::from_str(&raw_json)?;
         Ok(tasks)
     }
 
     /// Get all tasks in the today list from Things
-    pub fn today(from: &String, to: &String) -> Result<Vec<Task>> {
-        Task::from_script(include_bytes!("today.js"), TaskParams { from: from.to_string(), to: to.to_string() })
+    pub fn today() -> Result<Vec<Task>> {
+        Task::from_script(include_bytes!("today.js"))
     }
 
     /// Get all tasks in the logbook list from Things
-    pub fn logbook(from: &String, to: &String) -> Result<Vec<Task>> {
-        Task::from_script(include_bytes!("logbook.js"), TaskParams { from: from.to_string(), to: to.to_string() })
+    pub fn logbook_today() -> Result<Vec<Task>> {
+        Task::from_script(include_bytes!("logbook.js"))
+    }
+
+    pub fn logbook_this_cycle() -> Result<Vec<Task>> {
+        Task::from_script(include_bytes!("logbook_cycle.js"))
     }
 
     pub fn has_tag(&self, tag: &str) -> bool {

src/things/today.js

@@ -15,13 +15,7 @@ today.forEach(todo => {
     notes: todo.notes() || null,
     status: todo.status(),
     completion_date: todo.completionDate(),
-    project: proj && {
-      id: proj.id(),
-      title: proj.name(),
-      status: proj.status(),
-      notes: proj.notes(),
-      tags: proj.tagNames().split(', '),
-    },
+    project: proj && { id: proj.id(), title: proj.name() },
     area: area && { id: area.id(), title: area.name() },
     tags: [...tags, ...todo.tagNames().split(', ')].filter(t => t),
   });